Page MenuHomePhabricator

Continue after rejecting commits from a commit query
ClosedPublic

Authored by epriestley on Jan 6 2015, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 8 2024, 2:31 AM
Unknown Object (File)
Feb 3 2024, 1:49 AM
Unknown Object (File)
Feb 3 2024, 1:48 AM
Unknown Object (File)
Feb 3 2024, 1:48 AM
Unknown Object (File)
Feb 1 2024, 12:19 AM
Unknown Object (File)
Jan 22 2024, 12:55 AM
Unknown Object (File)
Jan 13 2024, 8:21 AM
Unknown Object (File)
Jan 5 2024, 4:01 PM

Details

Summary

Fixes T6880. If matching commits have no visible/loadable repository, we shouldn't keep going forward in the loop.

Test Plan

Havne't built a repro locally yet so not 100% sure this fixes it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Continue after rejecting commits from a commit query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: fabe, btrahan.
mbishopim3 added a reviewer: mbishopim3.
mbishopim3 added a subscriber: mbishopim3.

Confirmed working for our users.

This revision is now accepted and ready to land.Jan 6 2015, 3:51 PM
fabe edited edge metadata.

I've reproduced it locally and this fixes it. Before the patch these were two separate foreaches.

We could still link the commit (like we do with a repo that is not accessible) and make it show "restricted" instead.
With this patch the commits would simply ne be linked at all.

This revision was automatically updated to reflect the committed changes.