Revert "Remove an empty div"
ClosedPublic
Actions

Authored by Krenair on Jan 2 2015, 5:05 PM.

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6852: Buttons break out of box when registering new users

Commits

Restricted Diffusion Commit
rP2660b944bed4: Revert "Remove an empty div"

Summary

This reverts commit a896494ce582a238ce130efc87b68cd1b301580e which caused T6852

Test Plan

Check, for example, the position of the 'Save Account Settings' button

Diff Detail

Repository

rP Phabricator

Branch

T6852

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/view/form/control/AphrontFormControl.php:245	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 3493
Build 3500: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

Krenair updated this revision to Diff 26771.Jan 2 2015, 5:05 PM

Krenair added a task: T6852: Buttons break out of box when registering new users.

Krenair retitled this revision from to Revert "Remove an empty div".

Krenair updated this object.

Krenair edited the test plan for this revision. (Show Details)

Krenair added reviewers: epriestley, joshuaspence.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 2 2015, 5:05 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 2 2015, 5:09 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 2 2015, 5:09 PM

Closed by commit rP2660b944bed4: Revert "Remove an empty div" (authored by Krenair, committed by epriestley). · Explain WhyJan 2 2015, 5:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

AphrontFormControl.php

3 lines

Diff 26771

View Options

src/view/form/control/AphrontFormControl.php

Revert "Remove an empty div"ClosedPublicActions