Page MenuHomePhabricator

Remove deprecated task subscriber class
ClosedPublic

Authored by joshuaspence on Jan 1 2015, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 10:38 PM
Unknown Object (File)
Mon, Mar 25, 10:38 PM
Unknown Object (File)
Mon, Mar 25, 10:38 PM
Unknown Object (File)
Mon, Mar 25, 10:37 PM
Unknown Object (File)
Wed, Mar 20, 1:43 AM
Unknown Object (File)
Wed, Mar 20, 1:43 AM
Unknown Object (File)
Fri, Mar 1, 1:28 PM
Unknown Object (File)
Feb 6 2024, 9:25 PM
Subscribers

Details

Reviewers
epriestley
btrahan
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPc7cd844a07f8: Remove deprecated task subscriber class
Summary

This class is no longer used after D10965.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Remove deprecated task subscriber class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 1 2015, 11:37 PM
joshuaspence requested a review of this revision.EditedJan 3 2015, 12:09 AM
joshuaspence edited edge metadata.

It looks like I need to actually drop the table as well, otherwise I get the following error when running arc unit --everything:

Attempt to connect to root@localhost failed with error #1049: Unknown database 'phabricator_cache'. at [<phutil>/src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:72]

I think that this is the same as D10965#99046.

I think this is fine, it's had enough time to soak that I think we're in the clear.

(Although I don't know how you're getting that error.)

I would expect bin/storage adjust to complain that the table was surplus.

I think this is fine, it's had enough time to soak that I think we're in the clear.

OK, I bumped this back to "Needs Review" because I wanted approval for the migration. Feel free to re-accept.

Here's the full output (without the migration):

> arc unit --everything 
Exception
Command failed with error #2!
COMMAND
php '/home/joshua/workspace/github.com/phacility/phabricator/scripts/sql/manage_storage.php' upgrade --force --namespace 'phabricator_unittest_r6kwgp6tgmt5r56mgnqw5y6u'

STDOUT
Loading quickstart template...
Applying patch 'phabricator:20141106.uniqdrafts.php'...
Applying patch 'phabricator:20141107.phriction.policy.1.sql'...
Applying patch 'phabricator:20141107.phriction.policy.2.php'...
Populating Phriction policies.
Done.
Applying patch 'phabricator:20141107.phriction.popkeys.php'...
Populating Phriction mailkeys.
Done.
Applying patch 'phabricator:20141107.ssh.1.colname.sql'...
Applying patch 'phabricator:20141107.ssh.2.keyhash.sql'...
Applying patch 'phabricator:20141107.ssh.3.keyindex.sql'...
Applying patch 'phabricator:20141107.ssh.4.keymig.php'...
Updating SSH public key indexes...
Done.
Applying patch 'phabricator:20141107.ssh.5.indexnull.sql'...
Applying patch 'phabricator:20141107.ssh.6.indexkey.sql'...
Applying patch 'phabricator:20141107.ssh.7.colnull.sql'...
Applying patch 'phabricator:20141113.auditdupes.php'...
Removing duplicate Audit requests...
Done.
Applying patch 'phabricator:20141118.diffxaction.sql'...
Applying patch 'phabricator:2014111... (2,728 more bytes) ...

STDERR
[2015-01-03 11:10:43] EXCEPTION: (AphrontConnectionQueryException) Attempt to connect to root@localhost failed with error #1049: Unknown database 'phabricator_cache'. at [<phutil>/src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:72]
  #0 AphrontMySQLiDatabaseConnection::connect() called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:97]
  #1 AphrontBaseMySQLDatabaseConnection::establishConnection() called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:120]
  #2 AphrontBaseMySQLDatabaseConnection::requireConnection() called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:156]
  #3 AphrontBaseMySQLDatabaseConnection::executeRawQuery(string) called at [<phutil>/src/xsprintf/queryfx.php:6]
  #4 queryfx(AphrontMySQLiDatabaseConnection, string, string) called at [<phabricator>/src/applications/cache/management/PhabricatorCacheManagementPurgeWork... (565 more bytes) ...
(Run with --trace for a full exception trace.)
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 3 2015, 12:12 AM

Oh, I think it's "surplus" interacting with T6548.

And yes, ./bin storage adjust also would complain:

> ./bin/storage adjust
Verifying database schemata...
Found no adjustments for schemata.

Target                                         Error  
phabricator_maniphest.maniphest_tasksubscriber Surplus

 SURPLUS SCHEMATA 

You have surplus schemata (extra tables or columns which Phabricator does not
expect). For information on resolving these issues, see the "Surplus
Schemata" section in the "Managing Storage Adjustments" article in the
documentation.

Oh, I think it's "surplus" interacting with T6548.

Ah, quite possibly.

This revision was automatically updated to reflect the committed changes.