Paths

Table of Contentst

Differential D11116

Modernize remaining edge types
ClosedPublic
Actions

Authored by joshuaspence on Jan 1 2015, 6:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 4, 2:36 AM

	Unknown Object (File)
	Tue, Feb 4, 2:36 AM

	Unknown Object (File)
	Tue, Feb 4, 2:35 AM

	Unknown Object (File)
	Tue, Feb 4, 2:35 AM

	Unknown Object (File)
	Tue, Feb 4, 1:45 AM

	Unknown Object (File)
	Tue, Feb 4, 1:45 AM

	Unknown Object (File)
	Tue, Feb 4, 1:45 AM

	Unknown Object (File)
	Tue, Feb 4, 1:45 AM

Subscribers

Tokens

"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP7c2a7d03651c: Modernize remaining edge types

Summary

Modernize remaining edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan

Browsed around and performed various actions include subscribing, unsubscribing and watching.

Diff Detail

Repository

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/transactions/edges/PhabricatorObjectHasSubscriberEdgeType.php:8	PHL1	Unknown Symbol
Error	src/applications/transactions/edges/PhabricatorObjectHasUnsubscriberEdgeType.php:3	XHP19	Class-Filename Mismatch
Error	src/applications/transactions/edges/PhabricatorObjectUnsubscribedFromObjectEdgeType.php:9	PHL1	Unknown Symbol
Warning	src/applications/differential/editor/DifferentialTransactionEditor.php:1509	XHP25	Spaces Inside Parentheses
Warning	src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php:68	XHP37	Call Formatting
Warning	src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1850	XHP37	Call Formatting

Unit

Test Failures

Build Status

Buildable 3441
Build 3448: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	testCycleDetection
	0 ms	testFileVisibility
	0 ms	testJoinLeaveProject
	0 ms	testViewProject
	0 ms	testApplicationsInstalled
		View Full Test Results (4 Failed · 18 Passed)

Event Timeline

joshuaspence updated this revision to Diff 26692.Jan 1 2015, 6:12 AM

joshuaspence retitled this revision from to Modernize remaining edge types.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 1 2015, 6:12 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Finish it off

joshuaspence added a parent revision: D11114: Modernize Dashboard edges.Jan 1 2015, 12:34 PM

joshuaspence updated this object.

joshuaspence added a reviewer: epriestley.

joshuaspence edited the test plan for this revision. (Show Details)

itsawesome

This revision is now accepted and ready to land.Jan 1 2015, 2:38 PM

epriestley awarded a token.Jan 1 2015, 2:38 PM

joshuaspence mentioned this in T6853: "Open Revisions Affecting These Files" should weight severity of changes.Jan 2 2015, 10:14 PM

joshuaspence edited the test plan for this revision. (Show Details)Jan 2 2015, 11:58 PM

joshuaspence edited edge metadata.

Closed by commit rP7c2a7d03651c: Modernize remaining edge types (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 2 2015, 11:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140210.projcfield.4.memmig.sql

2 lines

20140211.dx.3.migsubscriptions.sql

2 lines

20140731.audit.1.subscribers.php

2 lines

20140904.macroattach.php

2 lines

patches/

20130201.revisionunsubscribed.php

2 lines

20130703.legalpaddocdenorm.php

2 lines

20131121.repocredentials.2.mig.php

2 lines

src/

__phutil_library_map__.php

24 lines

applications/

audit/

storage/

PhabricatorAuditTransaction.php

2 lines

conpherence/

editor/

ConpherenceEditor.php

2 lines

mail/

ConpherenceReplyHandler.php

2 lines

query/

ConpherenceThreadQuery.php

2 lines

differential/

editor/

DifferentialTransactionEditor.php

2 lines

query/

DifferentialRevisionQuery.php

4 lines

storage/

DifferentialRevision.php

2 lines

files/

edge/

PhabricatorFileHasObjectEdgeType.php

15 lines

query/

PhabricatorFileQuery.php

2 lines

storage/

PhabricatorFile.php

4 lines

legalpad/

editor/

LegalpadDocumentEditor.php

4 lines

query/

LegalpadDocumentQuery.php

4 lines

maniphest/

query/

ManiphestTaskQuery.php

2 lines

passphrase/

controller/

PassphraseCredentialViewController.php

2 lines

edge/

PhabricatorCredentialsUsedByObjectEdgeType.php

16 lines

project/

controller/

PhabricatorProjectWatchController.php

2 lines

editor/

PhabricatorProjectTransactionEditor.php

4 lines

query/

PhabricatorProjectQuery.php

2 lines

repository/

editor/

PhabricatorRepositoryEditor.php

2 lines

subscriptions/

editor/

PhabricatorSubscriptionsEditor.php

6 lines

events/

PhabricatorSubscriptionsUIEventListener.php

2 lines

query/

PhabricatorSubscribersQuery.php

2 lines

transactions/

edges/

PhabricatorContributedToObjectEdgeType.php

15 lines

PhabricatorObjectHasContributorEdgeType.php

104 lines

PhabricatorObjectHasFileEdgeType.php

103 lines

PhabricatorObjectHasSubscriberEdgeType.php

103 lines

PhabricatorObjectHasUnsubscriberEdgeType.php

104 lines

PhabricatorObjectHasWatcherEdgeType.php

103 lines

PhabricatorObjectUnsubscribedFromObjectEdgeType.php

16 lines

PhabricatorObjectUsesCredentialsEdgeType.php

16 lines

PhabricatorSubscribedToObjectEdgeType.php

16 lines

PhabricatorWatcherHasObjectEdgeType.php

15 lines

editor/

PhabricatorApplicationTransactionCommentEditor.php

2 lines

PhabricatorApplicationTransactionEditor.php

6 lines

infrastructure/

edges/

constants/

PhabricatorEdgeConfig.php

107 lines

internationalization/

translation/

PhabricatorBaseEnglishTranslation.php

35 lines

Diff 26692

resources/sql/autopatches/20140210.projcfield.4.memmig.sql

Loading...

resources/sql/autopatches/20140211.dx.3.migsubscriptions.sql

Loading...

resources/sql/autopatches/20140731.audit.1.subscribers.php

Loading...

resources/sql/autopatches/20140904.macroattach.php

Loading...

resources/sql/patches/20130201.revisionunsubscribed.php

Loading...

resources/sql/patches/20130703.legalpaddocdenorm.php

Loading...

resources/sql/patches/20131121.repocredentials.2.mig.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...

src/applications/conpherence/mail/ConpherenceReplyHandler.php

Loading...

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/files/edge/PhabricatorFileHasObjectEdgeType.php

Loading...

src/applications/files/query/PhabricatorFileQuery.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...

src/applications/legalpad/query/LegalpadDocumentQuery.php

Loading...

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...

src/applications/passphrase/edge/PhabricatorCredentialsUsedByObjectEdgeType.php

Loading...

src/applications/project/controller/PhabricatorProjectWatchController.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/query/PhabricatorProjectQuery.php

Loading...

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php

Loading...

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

Loading...

src/applications/subscriptions/query/PhabricatorSubscribersQuery.php

Loading...

src/applications/transactions/edges/PhabricatorContributedToObjectEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorObjectHasFileEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorObjectHasSubscriberEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorObjectHasUnsubscriberEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorObjectUnsubscribedFromObjectEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorObjectUsesCredentialsEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorSubscribedToObjectEdgeType.php

Loading...

src/applications/transactions/edges/PhabricatorWatcherHasObjectEdgeType.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...