Page MenuHomePhabricator
Differential D11077

Use `new FutureIterator` instead of `Futures`
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 12:05 PM.
Tags
None
Referenced Files
F15395467: D11077.diff
Sun, Mar 16, 7:11 AM
F15382618: D11077.diff
Fri, Mar 14, 1:24 PM
F15354486: D11077.diff
Tue, Mar 11, 4:15 AM
F15294686: D11077.id26591.diff
Wed, Mar 5, 10:30 AM
Unknown Object (File)
Fri, Feb 28, 8:46 AM
Unknown Object (File)
Feb 8 2025, 12:30 AM
Unknown Object (File)
Feb 8 2025, 12:30 AM
Unknown Object (File)
Feb 8 2025, 12:30 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6829: The `Futures()` function violates naming conventions
Commits
Restricted Diffusion Commit
rP39ca2fdf649f: Use `new FutureIterator` instead of `Futures`
Summary

Ref T6829. Deprecate the Futures() function.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3375
Build 3382: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26591.Dec 30 2014, 12:05 PM
joshuaspence retitled this revision from to Use `new FutureIterator` instead of `Futures`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6829: The `Futures()` function violates naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 12:05 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 12:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 12:06 PM
joshuaspence mentioned this in D11081: Remove the `Futures()` method.Dec 30 2014, 12:21 PM
Closed by commit rP39ca2fdf649f: Use `new FutureIterator` instead of `Futures` (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 30 2014, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26591

View Options

scripts/symbols/generate_ctags_symbols.php

Loading...
View Options

scripts/symbols/generate_php_symbols.php

Loading...
View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/diffusion/DiffusionLintSaveRunner.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionTagsQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseSearchController.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

Loading...
View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...
View Options

src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php

Loading...
View Options

src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php

Loading...
View Options

src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php

Loading...
View Options

src/infrastructure/lint/linter/PhabricatorJavelinLinter.php

Loading...
Phabricator · Built by Phacility