Page MenuHomePhabricator
Differential D11081

Remove the `Futures()` method
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 12:21 PM.
Tags
None
Referenced Files
F14076556: D11081.id26606.diff
Thu, Nov 21, 6:14 PM
Unknown Object (File)
Mon, Nov 18, 3:37 PM
Unknown Object (File)
Thu, Nov 14, 10:53 AM
Unknown Object (File)
Wed, Nov 13, 11:44 AM
Unknown Object (File)
Sat, Nov 9, 10:17 PM
Unknown Object (File)
Wed, Nov 6, 3:56 AM
Unknown Object (File)
Tue, Oct 29, 4:40 AM
Unknown Object (File)
Oct 22 2024, 4:33 PM
View All Files
Subscribers
epriestley
Jeff-Symphony
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6829: The `Futures()` function violates naming conventions
Commits
rPHU9319f6d50d52: Remove the `Futures()` method
Summary

Fixes T6829. Removes the Futures() method in favor of calling new FutureIterator($futures) explicitly. Depends on D11077, D11078 and D11079.

Test Plan

We could possibly deprecate this function instead (with phutil_deprecated).

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26597.Dec 30 2014, 12:21 PM
joshuaspence retitled this revision from to Remove the `Futures()` method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6829: The `Futures()` function violates naming conventions.
joshuaspence added parent revisions: D11078: Use `new FutureIterator` instead of `Futures`, D11077: Use `new FutureIterator` instead of `Futures`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 12:21 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 12:33 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 12:33 PM
epriestley added a comment.Dec 30 2014, 12:34 PM

I think removing it outright is reasonable, this is a fairly advanced feature that probably has seen little/no third-party use.

Closed by commit rPHU9319f6d50d52: Remove the `Futures()` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 30 2014, 12:39 PM
This revision was automatically updated to reflect the committed changes.
Jeff-Symphony added a subscriber: Jeff-Symphony.Jan 6 2015, 10:28 PM

A little late to vote on this now, but deprecating would have been nicer.

I ran into this error, and it took a while to realize it was using an old forked version of Arcanist:

PHP Fatal error: Call to undefined function Futures() in ~/Tools/arcanist/src/repository/api/ArcanistGitAPI.php on line 612
joshuaspence added a comment.Jan 6 2015, 10:31 PM

I think that if you've forked rARC then you should probably fork rPHU as well.

joshuaspence mentioned this in D11269: Remove references to `Futures()` from the documentation.Jan 7 2015, 8:02 PM
joshuaspence mentioned this in rPHUb264db10ea7e: Remove references to `Futures()` from the documentation.Jan 8 2015, 12:04 AM

Revision Contents
Changeset List

Diff 26606

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/future/FutureIterator.php

Loading...
View Options

src/future/functions.php

Loading...
Phabricator · Built by Phacility