Page MenuHomePhabricator
Differential D11078

Use `new FutureIterator` instead of `Futures`
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 12:07 PM.
Tags
None
Referenced Files
F13987440: D11078.id26600.diff
Mon, Oct 21, 9:30 AM
F13980723: D11078.id26592.diff
Sat, Oct 19, 12:21 PM
F13976833: D11078.diff
Fri, Oct 18, 3:55 PM
Unknown Object (File)
Oct 2 2024, 2:42 PM
Unknown Object (File)
Sep 15 2024, 2:23 AM
Unknown Object (File)
Sep 15 2024, 2:22 AM
Unknown Object (File)
Sep 15 2024, 2:22 AM
Unknown Object (File)
Sep 15 2024, 2:21 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6829: The `Futures()` function violates naming conventions
Commits
rPHUe6fef2c60a35: Use `new FutureIterator` instead of `Futures`
Summary

Ref T6829. Deprecate the Futures() function.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26592.Dec 30 2014, 12:07 PM
joshuaspence retitled this revision from to Use `new FutureIterator` instead of `Futures`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6829: The `Futures()` function violates naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 12:07 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 12:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 12:08 PM
joshuaspence mentioned this in D11081: Remove the `Futures()` method.Dec 30 2014, 12:21 PM
Closed by commit rPHUe6fef2c60a35: Use `new FutureIterator` instead of `Futures` (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 30 2014, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
filesystem/
__tests__/
3 lines
future/
10 lines
exec/
__tests__/
2 lines
query/
2 lines
moduleutils/
4 lines

Diff 26600

View Options

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

Loading...
View Options

src/future/FutureIterator.php

Loading...
View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
View Options

src/future/query/QueryFuture.php

Loading...
View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...
Phabricator · Built by Phacility