Page MenuHomePhabricator

Phriction - move "move" to modern editor + transactions
ClosedPublic

Authored by btrahan on Oct 30 2014, 8:23 PM.

Details

Summary

Ref T4029. Much like D10756, D10761 this does the bare minimum to get things in there. I have a sticky with "TODOs" about moving the error-checking business logic into the editor in all three cases.

Up next - policy...

Test Plan

moved a document and it worked! verified no feed story. verified both documents involved looked good

Diff Detail

Repository
rP Phabricator
Branch
T4029p2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2917
Build 2921: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Phriction - move "move" to modern editor + transactions.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added subscribers: Korvin, epriestley.

lets see what we get here...

and let's see what this does

Sorry about the git hyjinx. This should be good to review now.

epriestley edited edge metadata.

Seems like a reasonable starting point.

This revision is now accepted and ready to land.Oct 31 2014, 11:36 PM
This revision was automatically updated to reflect the committed changes.