Page MenuHomePhabricator
Differential D10763

Phriction - move "move" to modern editor + transactions
ClosedPublic
Actions

Authored by btrahan on Oct 30 2014, 8:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 7:34 AM
Unknown Object (File)
Sat, Dec 28, 7:06 AM
Unknown Object (File)
Dec 14 2024, 2:54 PM
Unknown Object (File)
Dec 11 2024, 9:05 AM
Unknown Object (File)
Dec 10 2024, 12:01 AM
Unknown Object (File)
Dec 7 2024, 10:31 PM
Unknown Object (File)
Dec 7 2024, 5:07 AM
Unknown Object (File)
Nov 29 2024, 5:22 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4029: Support policies on Phriction wiki articles
Commits
Restricted Diffusion Commit
rPdd7d8cf910e6: Phriction - move "move" to modern editor + transactions
Summary

Ref T4029. Much like D10756, D10761 this does the bare minimum to get things in there. I have a sticky with "TODOs" about moving the error-checking business logic into the editor in all three cases.

Up next - policy...

Test Plan

moved a document and it worked! verified no feed story. verified both documents involved looked good

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25832.Oct 30 2014, 8:23 PM
btrahan added a task: T4029: Support policies on Phriction wiki articles.
btrahan retitled this revision from to Phriction - move "move" to modern editor + transactions.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added subscribers: Korvin, epriestley.
Harbormaster completed remote builds in B2914: Diff 25832.Oct 30 2014, 8:24 PM
btrahan updated this revision to Diff 25835.Oct 30 2014, 8:27 PM

lets see what we get here...

Harbormaster completed remote builds in B2917: Diff 25835.Oct 30 2014, 8:27 PM
btrahan updated this revision to Diff 25836.Oct 30 2014, 8:27 PM

and let's see what this does

Harbormaster completed remote builds in B2918: Diff 25836.Oct 30 2014, 8:28 PM
btrahan updated this revision to Diff 25837.Oct 30 2014, 8:30 PM

another

Harbormaster completed remote builds in B2919: Diff 25837.Oct 30 2014, 8:30 PM
btrahan added a comment.Oct 30 2014, 8:30 PM

Sorry about the git hyjinx. This should be good to review now.

epriestley accepted this revision.Oct 31 2014, 11:36 PM
epriestley edited edge metadata.

Seems like a reasonable starting point.

This revision is now accepted and ready to land.Oct 31 2014, 11:36 PM
Closed by commit rPdd7d8cf910e6: Phriction - move "move" to modern editor + transactions (authored by btrahan, committed by btrahan). · Explain WhyNov 5 2014, 8:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
controller/
90 lines
editor/
73 lines
storage/
57 lines

Diff 25895

View Options

src/applications/phriction/controller/PhrictionMoveController.php

Loading...
View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
View Options

src/applications/phriction/storage/PhrictionTransaction.php

Loading...
Phabricator · Built by Phacility