Phriction - start the move towards transactions and an editor
ClosedPublic
Actions

Authored by btrahan on Oct 29 2014, 10:11 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T4029: Support policies on Phriction wiki articles

Commits

Restricted Diffusion Commit
rPa9fc343d9eda: Phriction - start the move towards transactions and an editor

Summary

This implements as little as possible to stick a working transactions + editor codepath in the basic create / edit flow. Aside from the transaction tables, this also required adding a mailKey to a phrictionDocument.

Future work would include adding more transactions types for things like "move" and all the pertinent support. Even future work is to add things like policies which will work easily in the transaction framework. Ref T4029.

Test Plan

made a wiki doc
edit a wiki doc
had someone subscribe to a wiki doc and edited it

For all three, the edits worked, a reasonable email was sent out, and feed stories were generated.

made a wiki doc at a /location/like/this

document "stubs" were made as expected in /location and /location/like

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25818.Oct 29 2014, 10:11 PM

btrahan added a task: T4029: Support policies on Phriction wiki articles.

btrahan retitled this revision from to Phriction - start the move towards transactions and an editor.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 29 2014, 10:11 PM

Harbormaster completed remote builds in B2903: Diff 25818.Oct 29 2014, 10:12 PM

hach-que awarded a token.Oct 29 2014, 10:12 PM

This is nice. Give me a sec and I'll see if I can get to the bottom of the feed thing.

resources/sql/autopatches/20141025.phriction.2.xaction.sql
17	This AUTO_INCREMENT=6 is probably from a dump or something?
src/applications/phriction/editor/PhrictionTransactionEditor.php
230	Minor, can just pass `$title`.
src/applications/phriction/mail/PhrictionReplyHandler.php
18	These could be PhrictionDocumentPHIDType::TYPECONST or whatever, I think.

changes from the inlines... thanks!

Harbormaster completed remote builds in B2905: Diff 25820.Oct 29 2014, 10:28 PM

I think the feed story issue is because there's no PhrictionTransactionQuery. The feed story tries to load the wiki page (which works) and the transaction(s) (which fail because no query class exists to load them).

chad awarded a token.Oct 29 2014, 10:35 PM