Page MenuHomePhabricator

Phriction - start the move towards transactions and an editor
ClosedPublic

Authored by btrahan on Oct 29 2014, 10:11 PM.

Details

Summary

This implements as little as possible to stick a working transactions + editor codepath in the basic create / edit flow. Aside from the transaction tables, this also required adding a mailKey to a phrictionDocument.

Future work would include adding more transactions types for things like "move" and all the pertinent support. Even future work is to add things like policies which will work easily in the transaction framework. Ref T4029.

Test Plan
  • made a wiki doc
  • edit a wiki doc
  • had someone subscribe to a wiki doc and edited it

For all three, the edits worked, a reasonable email was sent out, and feed stories were generated.

  • made a wiki doc at a /location/like/this

document "stubs" were made as expected in /location and /location/like

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Phriction - start the move towards transactions and an editor.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.

This is nice. Give me a sec and I'll see if I can get to the bottom of the feed thing.

resources/sql/autopatches/20141025.phriction.2.xaction.sql
17

This AUTO_INCREMENT=6 is probably from a dump or something?

src/applications/phriction/editor/PhrictionTransactionEditor.php
230

Minor, can just pass $title.

src/applications/phriction/mail/PhrictionReplyHandler.php
18

These could be PhrictionDocumentPHIDType::TYPECONST or whatever, I think.

btrahan edited edge metadata.

changes from the inlines... thanks!

I think the feed story issue is because there's no PhrictionTransactionQuery. The feed story tries to load the wiki page (which works) and the transaction(s) (which fail because no query class exists to load them).

add PhrictionTransactionQuery class, thus fixing feed

epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 29 2014, 11:20 PM
btrahan edited edge metadata.
btrahan edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.