Details

Reviewers

Maniphest Tasks

T4029: Support policies on Phriction wiki articles

Commits

Restricted Diffusion Commit
rPbdbb77183074: Phriction - move delete to modern editor + transactions

Summary

Ref T4029. Much like D10756 this does the bare minimum to get things in there. I have a sticky with "TODOs" about moving the error-checking business logic into the editor in both cases.

Up next - move actions...

Test Plan

deleted a document and it worked! verified proper feed story.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25829.Oct 30 2014, 4:47 PM

btrahan added a task: T4029: Support policies on Phriction wiki articles.

btrahan retitled this revision from to Phriction - move delete to modern editor + transactions.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 30 2014, 4:47 PM

Harbormaster completed remote builds in B2911: Diff 25829.Oct 30 2014, 4:48 PM

shadowhand added a subscriber: shadowhand.Oct 30 2014, 5:05 PM

shadowhand added inline comments.

src/applications/phriction/controller/PhrictionDeleteController.php
36–38	if this is meant to be PSR style, the `);` needs to be on a new line
src/applications/phriction/editor/PhrictionTransactionEditor.php
295–301
src/applications/phriction/storage/PhrictionTransaction.php
97	i kind of like the semantics of the `fa-close` alias, but not sure if that would be inconsistent with other TYPE_DELETEs.