Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4029: Support policies on Phriction wiki articles
- Commits
- Restricted Diffusion Commit
rPbdbb77183074: Phriction - move delete to modern editor + transactions
deleted a document and it worked! verified proper feed story.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/applications/phriction/controller/PhrictionDeleteController.php | ||
---|---|---|
36–38 | if this is meant to be PSR style, the ); needs to be on a new line | |
src/applications/phriction/editor/PhrictionTransactionEditor.php | ||
295–301 | ||
src/applications/phriction/storage/PhrictionTransaction.php | ||
97 | i kind of like the semantics of the fa-close alias, but not sure if that would be inconsistent with other TYPE_DELETEs. |
Comment Actions
this is the actual diff; I haven't done a branch of a branch in awhile and I forget my arc workflow
src/applications/phriction/storage/PhrictionTransaction.php | ||
---|---|---|
58–59 | This seems more important than a title change? Maybe? |