Page MenuHomePhabricator
Differential D10572

Extend `LINT_BRACE_FORMATTING` to support more scenarios
ClosedPublic
Actions

Authored by joshuaspence on Sep 26 2014, 6:53 AM.
Tags
None
Referenced Files
F15198328: D10572.diff
Sun, Feb 23, 2:11 AM
Unknown Object (File)
Sun, Feb 16, 11:50 PM
Unknown Object (File)
Sat, Feb 15, 5:06 AM
Unknown Object (File)
Wed, Feb 12, 3:23 AM
Unknown Object (File)
Fri, Feb 7, 4:11 AM
Unknown Object (File)
Sat, Feb 1, 6:46 PM
Unknown Object (File)
Sat, Feb 1, 7:53 AM
Unknown Object (File)
Mon, Jan 27, 2:06 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC4ca3463df684: Extend `LINT_BRACE_FORMATTING` to support more scenarios
Summary

Extend the ArcanistXHPASTLinter::LINT_BRACE_FORMATTING rule to support a bunch of extra cases.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2656
Build 2660: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25395.Sep 26 2014, 6:53 AM
joshuaspence retitled this revision from to Extend `LINT_BRACE_FORMATTING` to support more scenarios.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 26 2014, 6:53 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2656: Diff 25395.Sep 26 2014, 6:54 AM
joshuaspence added a parent revision: D10571: Extend `LINT_BRACE_FORMATTING` to warn on missing braces.Sep 26 2014, 8:31 AM
epriestley accepted this revision.Oct 3 2014, 11:04 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2014, 11:04 AM
Closed by commit rARC4ca3463df684: Extend `LINT_BRACE_FORMATTING` to support more scenarios (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 8 2014, 12:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25395

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/creative-brace-use.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/parens-hug-contents.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-after-control-keywords.lint-test

Loading...
Phabricator · Built by Phacility