Page MenuHomePhabricator

Extend `LINT_BRACE_FORMATTING` to warn on missing braces
ClosedPublic

Authored by joshuaspence on Sep 26 2014, 5:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 5, 9:35 AM
Unknown Object (File)
Jan 30 2025, 8:30 PM
Unknown Object (File)
Jan 24 2025, 11:44 AM
Unknown Object (File)
Jan 19 2025, 11:47 PM
Unknown Object (File)
Jan 19 2025, 11:43 PM
Unknown Object (File)
Jan 7 2025, 9:17 PM
Unknown Object (File)
Dec 30 2024, 6:37 AM
Unknown Object (File)
Dec 13 2024, 9:22 PM
Subscribers

Details

Summary

Extend the ArcanistXHPASTLinter::LINT_BRACE_FORMATTING rule to raise a warning when n_STATEMENT is used without having n_STATEMENT_LIST as a parent. Essentially, this means that if ($x) { do_y(); } is preferred over if ($x) do_y();.

Test Plan

Added some test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Extend `LINT_BRACE_FORMATTING` to warn on missing braces.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

This should maybe be a separate linter rule.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2014, 11:04 AM
This revision was automatically updated to reflect the committed changes.