Page MenuHomePhabricator
Differential D10572

Extend `LINT_BRACE_FORMATTING` to support more scenarios
ClosedPublic
Actions

Authored by joshuaspence on Sep 26 2014, 6:53 AM.
Tags
None
Referenced Files
F14001403: D10572.diff
Fri, Oct 25, 7:31 AM
Unknown Object (File)
Sun, Oct 13, 2:28 AM
Unknown Object (File)
Oct 3 2024, 12:13 AM
Unknown Object (File)
Sep 23 2024, 4:19 AM
Unknown Object (File)
Sep 4 2024, 11:35 PM
Unknown Object (File)
Sep 2 2024, 11:46 AM
Unknown Object (File)
Aug 26 2024, 11:29 AM
Unknown Object (File)
Aug 22 2024, 1:43 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC4ca3463df684: Extend `LINT_BRACE_FORMATTING` to support more scenarios
Summary

Extend the ArcanistXHPASTLinter::LINT_BRACE_FORMATTING rule to support a bunch of extra cases.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25395.Sep 26 2014, 6:53 AM
joshuaspence retitled this revision from to Extend `LINT_BRACE_FORMATTING` to support more scenarios.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 26 2014, 6:53 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2656: Diff 25395.Sep 26 2014, 6:54 AM
joshuaspence added a parent revision: D10571: Extend `LINT_BRACE_FORMATTING` to warn on missing braces.Sep 26 2014, 8:31 AM
epriestley accepted this revision.Oct 3 2014, 11:04 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2014, 11:04 AM
Closed by commit rARC4ca3463df684: Extend `LINT_BRACE_FORMATTING` to support more scenarios (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 8 2014, 12:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26280

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/creative-brace-use.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/parens-hug-contents.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-after-control-keywords.lint-test

Loading...
Phabricator · Built by Phacility