Paths

Table of Contentst

Differential D10197

Don't interpret `arc browse .` as a commit
ClosedPublic
Actions

Authored by epriestley on Aug 8 2014, 6:03 PM.

Tags

None

Referenced Files

	F14843644: D10197.diff
	Sun, Feb 2, 8:40 AM

	Unknown Object (File)
	Tue, Jan 28, 5:46 PM

	Unknown Object (File)
	Tue, Jan 28, 9:45 AM

	Unknown Object (File)
	Tue, Jan 28, 9:02 AM

	Unknown Object (File)
	Tue, Jan 28, 9:02 AM

	Unknown Object (File)
	Mon, Jan 27, 11:41 PM

	Unknown Object (File)
	Sat, Jan 25, 12:54 AM

	Unknown Object (File)
	Thu, Jan 23, 3:13 PM

Subscribers

Details

Reviewers

btrahan
avivey
chad
• avive

Maniphest Tasks

T5781: Moar functionality for `arc browse`!

Commits

rARC377eb5d1e0a2: Don't interpret `arc browse .` as a commit

Summary

Ref T5781. git show . works like HEAD, but that isn't what arc browse . means.

Test Plan

Ran arc browse . with a repository at a published commit.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24531.Aug 8 2014, 6:03 PM

epriestley retitled this revision from to Don't interpret `arc browse .` as a commit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan, • avive.

epriestley added a task: T5781: Moar functionality for `arc browse`!.

Herald added subscribers: avivey, epriestley. · View Herald TranscriptAug 8 2014, 6:03 PM

Harbormaster completed remote builds in B2114: Diff 24531.Aug 8 2014, 6:05 PM

Also use git show ... -- to prevent interpretation of the commit argument as a path.

Harbormaster completed remote builds in B2115: Diff 24532.Aug 8 2014, 6:08 PM

this now fails for me:

$ arc browse app
Exception
Command failed with error #128!
COMMAND
git show -s --format='%H' 'app' --

STDOUT
(empty)

STDERR
fatal: bad revision 'app'

(Run with --trace for a full exception trace.)

Better?

Harbormaster completed remote builds in B2116: Diff 24533.Aug 8 2014, 6:14 PM

Yes :)

(I'm still not sure what's the deal with git. It only does that trick for HEAD).

This revision is now accepted and ready to land.Aug 8 2014, 6:15 PM

Closed by commit rARC377eb5d1e0a2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

2 lines

workflow/

ArcanistBrowseWorkflow.php

16 lines

Diff 24534

src/repository/api/ArcanistGitAPI.php

Loading...

src/workflow/ArcanistBrowseWorkflow.php

Loading...