Page MenuHomePhabricator

Don't interpret `arc browse .` as a commit
ClosedPublic

Authored by epriestley on Aug 8 2014, 6:03 PM.

Details

Summary

Ref T5781. git show . works like HEAD, but that isn't what arc browse . means.

Test Plan

Ran arc browse . with a repository at a published commit.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24531.Aug 8 2014, 6:03 PM
epriestley retitled this revision from to Don't interpret `arc browse .` as a commit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan, avive.
epriestley updated this revision to Diff 24532.Aug 8 2014, 6:07 PM
  • Also use git show ... -- to prevent interpretation of the commit argument as a path.
avivey added a comment.Aug 8 2014, 6:09 PM

this now fails for me:

$ arc browse app
Exception
Command failed with error #128!
COMMAND
git show -s --format='%H' 'app' --

STDOUT
(empty)

STDERR
fatal: bad revision 'app'

(Run with --trace for a full exception trace.)
epriestley updated this revision to Diff 24533.Aug 8 2014, 6:13 PM
  • Better?
avivey accepted this revision.Aug 8 2014, 6:15 PM
avivey added a reviewer: avivey.

Yes :)

(I'm still not sure what's the deal with git. It only does that trick for HEAD).

This revision is now accepted and ready to land.Aug 8 2014, 6:15 PM
epriestley closed this revision.Aug 8 2014, 6:21 PM
epriestley updated this revision to Diff 24534.

Closed by commit rARC377eb5d1e0a2 (authored by @epriestley).