Page MenuHomePhabricator
Differential D10197

Don't interpret `arc browse .` as a commit
ClosedPublic
Actions

Authored by epriestley on Aug 8 2014, 6:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 1:39 AM
Unknown Object (File)
Wed, Feb 19, 4:20 AM
Unknown Object (File)
Thu, Feb 13, 7:23 AM
Unknown Object (File)
Sun, Feb 9, 4:06 AM
Unknown Object (File)
Fri, Feb 7, 10:21 PM
Unknown Object (File)
Fri, Feb 7, 10:21 PM
Unknown Object (File)
Fri, Feb 7, 10:21 PM
Unknown Object (File)
Fri, Feb 7, 10:21 PM
View All Files
Subscribers
avivey
epriestley

Details

Reviewers
btrahan
avivey
chad
• avive
Maniphest Tasks
T5781: Moar functionality for `arc browse`!
Commits
rARC377eb5d1e0a2: Don't interpret `arc browse .` as a commit
Summary

Ref T5781. git show . works like HEAD, but that isn't what arc browse . means.

Test Plan

Ran arc browse . with a repository at a published commit.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24531.Aug 8 2014, 6:03 PM
epriestley retitled this revision from to Don't interpret `arc browse .` as a commit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan, • avive.
epriestley added a task: T5781: Moar functionality for `arc browse`!.
Herald added subscribers: avivey, epriestley. · View Herald TranscriptAug 8 2014, 6:03 PM
Harbormaster completed remote builds in B2114: Diff 24531.Aug 8 2014, 6:05 PM
epriestley updated this revision to Diff 24532.Aug 8 2014, 6:07 PM
  • Also use git show ... -- to prevent interpretation of the commit argument as a path.
Harbormaster completed remote builds in B2115: Diff 24532.Aug 8 2014, 6:08 PM
avivey added a comment.Aug 8 2014, 6:09 PM

this now fails for me:

$ arc browse app
Exception
Command failed with error #128!
COMMAND
git show -s --format='%H' 'app' --

STDOUT
(empty)

STDERR
fatal: bad revision 'app'

(Run with --trace for a full exception trace.)
epriestley updated this revision to Diff 24533.Aug 8 2014, 6:13 PM
  • Better?
Harbormaster completed remote builds in B2116: Diff 24533.Aug 8 2014, 6:14 PM
avivey accepted this revision.Aug 8 2014, 6:15 PM
avivey added a reviewer: avivey.

Yes :)

(I'm still not sure what's the deal with git. It only does that trick for HEAD).

This revision is now accepted and ready to land.Aug 8 2014, 6:15 PM
epriestley closed this revision.Aug 8 2014, 6:21 PM
epriestley updated this revision to Diff 24534.

Closed by commit rARC377eb5d1e0a2 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
repository/
api/
2 lines
workflow/
16 lines

Diff 24534

View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/workflow/ArcanistBrowseWorkflow.php

Loading...
Phabricator · Built by Phacility