Page MenuHomePhabricator

Fix some issues with new Conduit method implementations
ClosedPublic

Authored by epriestley on Jul 25 2014, 4:53 AM.
Tags
None
Referenced Files
F14416325: D10049.diff
Tue, Dec 24, 9:44 PM
Unknown Object (File)
Sat, Dec 21, 5:08 PM
Unknown Object (File)
Fri, Dec 6, 8:20 AM
Unknown Object (File)
Thu, Dec 5, 6:21 PM
Unknown Object (File)
Wed, Nov 27, 10:35 PM
Unknown Object (File)
Nov 22 2024, 2:32 PM
Unknown Object (File)
Nov 18 2024, 9:42 PM
Unknown Object (File)
Nov 17 2024, 11:01 PM
Subscribers

Details

Summary

Ref T5655. A few of these were missed.

Test Plan

Checked all other methods like this:

foreach ($method_map as $k => $v) {
  $v = preg_replace('/ConduitAPIMethod$/', '', $v);
  $k = str_replace('.', '', $k);
  $v = strtolower($v);
  if ($k != $v) {
    echo "{$k} x {$v}!\n";
  }
}
echo "OK\n";

Diff Detail

Repository
rP Phabricator
Branch
mnames
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1894
Build 1895: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix some issues with new Conduit method implementations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: hach-que, joshuaspence.
This revision is now accepted and ready to land.Jul 25 2014, 4:56 AM
epriestley edited edge metadata.
epriestley updated this revision to Diff 24163.

Closed by commit rP20589389de75 (authored by @epriestley).