HomePhabricator

Respect token limits for "Assign to" and custom datasource fields in Herald

Description

Respect token limits for "Assign to" and custom datasource fields in Herald

Summary:
See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write [ Assign to ][ X, Y, Z ]. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan:

  • Created a "projects" custom field with limit 1.
  • Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  • Created an "add subscribers" action with more than one value.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18887

Details

Provenance
epriestleyAuthored on Jan 19 2018, 10:43 PM
epriestleyPushed on Jan 22 2018, 7:54 PM
Reviewer
amckinley
Differential Revision
D18887: Respect token limits for "Assign to" and custom datasource fields in Herald
Parents
rP6a6279705671: Fix some issues with Diffusion file data limits
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19120
Build 25817: Run Core Tests