Page MenuHomePhabricator

Respect token limits for "Assign to" and custom datasource fields in Herald
ClosedPublic

Authored by epriestley on Jan 19 2018, 10:46 PM.
Tags
None
Referenced Files
F18807063: D18887.id.diff
Sat, Oct 18, 10:50 PM
F18628592: D18887.diff
Sep 16 2025, 6:40 AM
F18625525: D18887.diff
Sep 15 2025, 10:58 PM
F18566453: D18887.id.diff
Sep 9 2025, 2:39 PM
F18501963: D18887.diff
Sep 4 2025, 10:05 PM
F18392247: D18887.id45299.diff
Aug 29 2025, 8:08 AM
F18387767: D18887.id.diff
Aug 29 2025, 3:40 AM
F18387058: D18887.id45299.diff
Aug 29 2025, 2:49 AM
Subscribers
None

Details

Summary

See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write [ Assign to ][ X, Y, Z ]. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan
  • Created a "projects" custom field with limit 1.
  • Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  • Created an "add subscribers" action with more than one value.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable