HomePhabricator

Track closed date and closing user for tasks explicitly

Authored by epriestley on Feb 8 2018, 10:20 PM.

Description

Track closed date and closing user for tasks explicitly

Summary:
Ref T4434. Although some of the use cases for this data are better fits for Facts, this data is reasonable to track separately.

I have an approximate view of it already ("closed, ordered by date modified") that's useful to review things that were fixed recently. This lets us make that view more effective.

This just adds (and populates) the storage. Followups will add Conduit, Export, Search, and UI support.

This is slightly tricky because merges work oddly (see T13020).

Test Plan:

  • Ran migration, checked database for sensible results.
  • Created a task in open/closed status, got the right database values.
  • Modified a task to close/open it, got the right values.
  • Merged an open task, got updates.

Maniphest Tasks: T4434

Differential Revision: https://secure.phabricator.com/D19037

Event Timeline

ftdysa added a subscriber: ftdysa.Feb 10 2018, 2:04 PM
ftdysa added inline comments.
/resources/sql/autopatches/20180208.maniphest.02.populate.php
25

I'm not sure if this is a bug or not, but $type_status is pointing to merge and $type_merge is pointing to status here. Sorry for the fly by review if this is by design!

Thanks, not intended.