Track closed date and closing user for tasks explicitly
f028aa6f60dd
Actions

Description

Track closed date and closing user for tasks explicitly

Summary:
Ref T4434. Although some of the use cases for this data are better fits for Facts, this data is reasonable to track separately.

I have an approximate view of it already ("closed, ordered by date modified") that's useful to review things that were fixed recently. This lets us make that view more effective.

This just adds (and populates) the storage. Followups will add Conduit, Export, Search, and UI support.

This is slightly tricky because merges work oddly (see T13020).

Test Plan:

Ran migration, checked database for sensible results.
Created a task in open/closed status, got the right database values.
Modified a task to close/open it, got the right values.
Merged an open task, got updates.

Maniphest Tasks: T4434

Differential Revision: https://secure.phabricator.com/D19037

Details

Provenance

epriestley	Authored on Feb 8 2018, 10:20 PM
epriestley	Pushed on Feb 8 2018, 11:40 PM

Differential Revision

D19037: Track closed date and closing user for tasks explicitly

Parents

rPd1e273daf62f: Remove completely pointless load of every repository when viewing a repository…

Branches

Unknown

Tags

Unknown

Tasks

T4434: Track object closed/completed date and actor

Build Status

Buildable 19444
Build 26302: Run Core Tests

Event Timeline

epriestley committed rPf028aa6f60dd: Track closed date and closing user for tasks explicitly (authored by epriestley).Feb 8 2018, 11:40 PM

epriestley added a task: T4434: Track object closed/completed date and actor.

ftdysa added a subscriber: ftdysa.Feb 10 2018, 2:04 PM

ftdysa added inline comments.

/resources/sql/autopatches/20180208.maniphest.02.populate.php
25	I'm not sure if this is a bug or not, but `$type_status` is pointing to merge and `$type_merge` is pointing to status here. Sorry for the fly by review if this is by design!