Page MenuHomePhabricator

Track closed date and closing user for tasks explicitly
ClosedPublic

Authored by epriestley on Feb 8 2018, 10:46 PM.

Details

Summary

Ref T4434. Although some of the use cases for this data are better fits for Facts, this data is reasonable to track separately.

I have an approximate view of it already ("closed, ordered by date modified") that's useful to review things that were fixed recently. This lets us make that view more effective.

This just adds (and populates) the storage. Followups will add Conduit, Export, Search, and UI support.

This is slightly tricky because merges work oddly (see T13020).

Test Plan
  • Ran migration, checked database for sensible results.
  • Created a task in open/closed status, got the right database values.
  • Modified a task to close/open it, got the right values.
  • Merged an open task, got updates.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 8 2018, 10:46 PM
epriestley requested review of this revision.Feb 8 2018, 10:47 PM
epriestley updated this revision to Diff 45646.Feb 8 2018, 10:53 PM
  • For consistency with other terms (authorPHID, ownerPHID, etc), call this "closerPHID", not "closingPHID".
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 11:40 PM
This revision was automatically updated to reflect the committed changes.