Page MenuHomePhabricator

Improve handling of "Deny" responses from Duo
ClosedPublic

Authored by epriestley on Jan 30 2019, 5:18 AM.
Tags
None
Referenced Files
F12857700: D20065.id47900.diff
Fri, Mar 29, 10:48 AM
Unknown Object (File)
Sat, Mar 23, 11:16 PM
Unknown Object (File)
Wed, Mar 13, 7:16 PM
Unknown Object (File)
Tue, Mar 5, 2:23 AM
Unknown Object (File)
Feb 19 2024, 3:28 PM
Unknown Object (File)
Feb 15 2024, 10:09 PM
Unknown Object (File)
Feb 3 2024, 9:07 PM
Unknown Object (File)
Jan 13 2024, 3:37 AM
Subscribers
None

Details

Summary

Ref T13231. See https://discourse.phabricator-community.org/t/duo-integration-crashes-if-user-is-not-enrolled-and-enrollment-is-disabled/2340/5

(There's an actual bug here, although I'm not sure exactly what's going on on the Duo side in the report.)

Test Plan

To reproduce this, I was only able to actually "Deny" my account explicitly in Duo.

  • With "Deny", tried to add a factor. Got a nice helpful error message.
  • Undenied, added a factor, re-denied, tried to pass an MFA gate. Got another nice helpful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/auth/factor/PhabricatorDuoAuthFactor.php
386–387

"The The"

This revision is now accepted and ready to land.Jan 31 2019, 2:45 AM
This revision was automatically updated to reflect the committed changes.