Page MenuHomePhabricator

Improve handling of "Deny" responses from Duo

Authored by epriestley on Jan 30 2019, 5:18 AM.



Ref T13231. See

(There's an actual bug here, although I'm not sure exactly what's going on on the Duo side in the report.)

Test Plan

To reproduce this, I was only able to actually "Deny" my account explicitly in Duo.

  • With "Deny", tried to add a factor. Got a nice helpful error message.
  • Undenied, added a factor, re-denied, tried to pass an MFA gate. Got another nice helpful error message.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 30 2019, 5:18 AM
epriestley requested review of this revision.Jan 30 2019, 5:19 AM
amckinley accepted this revision.Jan 31 2019, 2:45 AM
amckinley added inline comments.

"The The"

This revision is now accepted and ready to land.Jan 31 2019, 2:45 AM
epriestley updated this revision to Diff 47928.Jan 31 2019, 3:28 AM
  • Typo fix.
This revision was automatically updated to reflect the committed changes.