Page MenuHomePhabricator

Improve handling of "Deny" responses from Duo
ClosedPublic

Authored by epriestley on Wed, Jan 30, 5:18 AM.

Details

Summary

Ref T13231. See https://discourse.phabricator-community.org/t/duo-integration-crashes-if-user-is-not-enrolled-and-enrollment-is-disabled/2340/5

(There's an actual bug here, although I'm not sure exactly what's going on on the Duo side in the report.)

Test Plan

To reproduce this, I was only able to actually "Deny" my account explicitly in Duo.

  • With "Deny", tried to add a factor. Got a nice helpful error message.
  • Undenied, added a factor, re-denied, tried to pass an MFA gate. Got another nice helpful error message.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jan 30, 5:18 AM
epriestley requested review of this revision.Wed, Jan 30, 5:19 AM
amckinley accepted this revision.Thu, Jan 31, 2:45 AM
amckinley added inline comments.
src/applications/auth/factor/PhabricatorDuoAuthFactor.php
386–387

"The The"

This revision is now accepted and ready to land.Thu, Jan 31, 2:45 AM
epriestley updated this revision to Diff 47928.Thu, Jan 31, 3:28 AM
  • Typo fix.
This revision was automatically updated to reflect the committed changes.