Make "Delete" from inline comment previews function correctly while editing…
e7ebd5d9d1f8
Actions

Description

Make "Delete" from inline comment previews function correctly while editing comments

Summary: Ref T13513. Currently, if you're editing a comment, "delete" doesn't put the comment into the correct state. This action is normally only reachable from comment previews, since an editing inline has no "delete" button.

Test Plan:

Started editing an inline, clicked "Delete", got a deletion.
Created an inline, typed text,
Deleted a normal comment via preview.
Deleted a normal comment via the on-inline action.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21238

Details

Provenance

epriestley	Authored on May 8 2020, 2:59 PM
epriestley	Pushed on May 8 2020, 3:54 PM

Differential Revision

D21238: Make "Delete" from inline comment previews function correctly while editing comments

Parents

rPb804e8cffad2: Make "View" from inline comment previews correctly jump to "isEditing" inlines

Branches

Unknown

Tags

Unknown

Tasks

T13513: Make schema changes to inlines to prepare for new inline features

Build Status

Buildable 24394
Build 33609: Run Core Tests

Event Timeline

epriestley committed rPe7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing… (authored by epriestley).May 8 2020, 3:54 PM

epriestley added a task: T13513: Make schema changes to inlines to prepare for new inline features.

epriestley added an edge: D21238: Make "Delete" from inline comment previews function correctly while editing comments.

Harbormaster completed building B24394: rPe7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing….May 8 2020, 3:56 PM

epriestley mentioned this in 2020 Week 18 (Early May).May 8 2020, 9:22 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

rPe7ebd5d9d1f8

View Options

resources/celerity/map.php