Page MenuHomePhabricator

Make "Delete" from inline comment previews function correctly while editing comments
ClosedPublic

Authored by epriestley on Fri, May 8, 3:09 PM.

Details

Summary

Ref T13513. Currently, if you're editing a comment, "delete" doesn't put the comment into the correct state. This action is normally only reachable from comment previews, since an editing inline has no "delete" button.

Test Plan
  • Started editing an inline, clicked "Delete", got a deletion.
  • Created an inline, typed text,
  • Deleted a normal comment via preview.
  • Deleted a normal comment via the on-inline action.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 8, 3:09 PM
epriestley requested review of this revision.Fri, May 8, 3:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 8, 3:54 PM
This revision was automatically updated to reflect the committed changes.