Page MenuHomePhabricator

Make "Delete" from inline comment previews function correctly while editing comments
ClosedPublic

Authored by epriestley on May 8 2020, 3:09 PM.
Tags
None
Referenced Files
F12832653: D21238.diff
Thu, Mar 28, 1:32 PM
Unknown Object (File)
Mon, Mar 25, 10:43 PM
Unknown Object (File)
Dec 27 2023, 1:24 PM
Unknown Object (File)
Dec 24 2023, 8:25 PM
Unknown Object (File)
Dec 22 2023, 2:58 AM
Unknown Object (File)
Nov 30 2023, 12:59 AM
Unknown Object (File)
Nov 15 2023, 11:25 AM
Unknown Object (File)
Sep 27 2023, 6:24 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you're editing a comment, "delete" doesn't put the comment into the correct state. This action is normally only reachable from comment previews, since an editing inline has no "delete" button.

Test Plan
  • Started editing an inline, clicked "Delete", got a deletion.
  • Created an inline, typed text,
  • Deleted a normal comment via preview.
  • Deleted a normal comment via the on-inline action.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 3:54 PM
This revision was automatically updated to reflect the committed changes.