HomePhabricator

Added some additional assertion methods.

Description

Added some additional assertion methods.

Summary:
There are quite a few tests in Arcanist, libphutil and Phabricator that do something similar to $this->assertEqual(false, ...) or $this->assertEqual(true, ...).

This is unnecessarily verbose and it would be cleaner if we had assertFalse and assertTrue methods.

Test Plan: I contemplated adding a unit test for the getCallerInfo method but wasn't sure if it was required / where it should live.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8460

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on Mar 9 2014, 3:16 AM
epriestleyPushed on Mar 9 2014, 3:16 AM
Reviewer
epriestley
Differential Revision
D8460: Added some additional assertion methods.
Parents
rP08040ae984ad: Fix action links in documentview
Branches
Unknown
Tags
Unknown

Event Timeline