HomePhabricator

Clean up a ConduitException around Diffusion merges

Description

Clean up a ConduitException around Diffusion merges

Summary:
Ref T7123. Two general issues:

For proxied repositories, we currently throw a ConduitClientException, vs ConduitException for local repositories. This is inconsistent and we should fix it, but I also want to examine the use of try-the-call-and-throw at these sites since it may be something we can update. In particular, trying a call that we know will always fail is now more expensive (in proxied repositories) than it used to be.

Here, we try-and-throw for merges, but they're never supported in Subversion. Just don't bother trying.

Test Plan: Browsed a SVN repository with proxying set up, got a clean commit page.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7123

Differential Revision: https://secure.phabricator.com/D11646

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Feb 3 2015, 5:54 PM
Reviewer
btrahan
Differential Revision
D11646: Clean up a ConduitException around Diffusion merges
Parents
rP3b6100d620ef: Fix lookup of commits in Subversion
Branches
Unknown
Tags
Unknown
Tasks
T7123: Clean up `catch (ConduitException $ex)` in Diffusion