Page MenuHomePhabricator

Clean up a ConduitException around Diffusion merges
ClosedPublic

Authored by epriestley on Feb 3 2015, 2:03 PM.
Tags
None
Referenced Files
F18092679: D11646.id28025.diff
Thu, Aug 7, 12:26 PM
F18088022: D11646.id28025.diff
Wed, Aug 6, 6:35 AM
F18087797: D11646.id28037.diff
Wed, Aug 6, 5:36 AM
F18054647: D11646.diff
Mon, Aug 4, 6:30 AM
Unknown Object (File)
Jun 19 2025, 3:53 PM
Unknown Object (File)
May 7 2025, 9:09 PM
Unknown Object (File)
May 4 2025, 9:57 PM
Unknown Object (File)
Apr 29 2025, 7:34 AM
Subscribers

Details

Summary

Ref T7123. Two general issues:

For proxied repositories, we currently throw a ConduitClientException, vs ConduitException for local repositories. This is inconsistent and we should fix it, but I also want to examine the use of try-the-call-and-throw at these sites since it may be something we can update. In particular, trying a call that we know will always fail is now more expensive (in proxied repositories) than it used to be.

Here, we try-and-throw for merges, but they're never supported in Subversion. Just don't bother trying.

Test Plan

Browsed a SVN repository with proxying set up, got a clean commit page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Clean up a ConduitException around Diffusion merges.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 5:51 PM
This revision was automatically updated to reflect the committed changes.