Page MenuHomePhabricator

Clean up a ConduitException around Diffusion merges
ClosedPublic

Authored by epriestley on Feb 3 2015, 2:03 PM.
Tags
None
Referenced Files
F15437008: D11646.diff
Tue, Mar 25, 5:00 PM
F15413826: D11646.diff
Wed, Mar 19, 9:31 PM
F15397187: D11646.diff
Sun, Mar 16, 6:42 PM
F15397014: D11646.id28025.diff
Sun, Mar 16, 5:39 PM
F15396558: D11646.id28037.diff
Sun, Mar 16, 3:06 PM
F15386535: D11646.id.diff
Sat, Mar 15, 12:48 AM
F15337683: D11646.id28025.diff
Sun, Mar 9, 7:05 AM
Unknown Object (File)
Feb 22 2025, 3:38 PM
Subscribers

Details

Summary

Ref T7123. Two general issues:

For proxied repositories, we currently throw a ConduitClientException, vs ConduitException for local repositories. This is inconsistent and we should fix it, but I also want to examine the use of try-the-call-and-throw at these sites since it may be something we can update. In particular, trying a call that we know will always fail is now more expensive (in proxied repositories) than it used to be.

Here, we try-and-throw for merges, but they're never supported in Subversion. Just don't bother trying.

Test Plan

Browsed a SVN repository with proxying set up, got a clean commit page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Clean up a ConduitException around Diffusion merges.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 5:51 PM
This revision was automatically updated to reflect the committed changes.