Page MenuHomePhabricator
Create Task
Maniphest T7123

Clean up `catch (ConduitException $ex)` in Diffusion
Closed, ResolvedPublic
Actions

Description

For proxied repositories, this may actually be a ConduitClientException. We should make the stack throw a consistent exception, but likely also reduce the reliance of Diffusion on catching these.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley created this task.Feb 3 2015, 1:52 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Phacility.
epriestley added a subscriber: epriestley.
epriestley added a revision: Restricted Differential Revision.Feb 3 2015, 2:03 PM
epriestley added a commit: Restricted Diffusion Commit.Feb 3 2015, 5:54 PM
epriestley moved this task from Backlog to v1 Open Beta on the Phacility board.Feb 4 2015, 8:22 PM
epriestley assigned this task to btrahan.Feb 13 2015, 8:00 PM
  • I think we should make callConduitWithDiffusionRequest() always throw ConduitClientException (never ConduitException), I guess?
  • But maybe look through callsites and see if they can all be removed like D11646. Since calls have a nontrivial cost now, it's better if we can avoid making calls that will fail. If they can, we could ignore the exception inconsistency.
joshuaspence added a project: Diffusion.Feb 14 2015, 12:48 PM
joshuaspence added a subscriber: joshuaspence.
btrahan added a revision: Restricted Differential Revision.Feb 17 2015, 9:06 PM
btrahan added a commit: Restricted Diffusion Commit.Feb 17 2015, 10:01 PM
btrahan closed this task as Resolved.Feb 17 2015, 10:01 PM

D11789 ended up taking care of all of these.

Phabricator · Built by Phacility