HomePhabricator

Give sessions real PHIDs and slightly modernize session queries

Description

Give sessions real PHIDs and slightly modernize session queries

Summary:
Ref T13222. See PHI873. I'm preparing to introduce a new MFA "Challenge" table which stores state about challenges we've issued (to bind challenges to sessions and prevent most challenge reuse).

This table will reference sessions (since each challenge will be bound to a particular session) but sessions currently don't have PHIDs. Give them PHIDs and slightly modernize some related code.

Test Plan:

  • Ran migrations.
  • Verified table got PHIDs.
  • Used var_dump() to dump an organic user session.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13222

Differential Revision: https://secure.phabricator.com/D19881

Details

Provenance
epriestleyAuthored on Dec 13 2018, 6:13 PM
epriestleyPushed on Dec 14 2018, 12:14 AM
Reviewer
amckinley
Differential Revision
D19881: Give sessions real PHIDs and slightly modernize session queries
Parents
rPecae936d9701: Fix another qsprintf() straggler in "Has Open Subtasks"
Branches
Unknown
Tags
Unknown
Tasks
T13222: 2018 Week 48-51 Bonus Content
Build Status
Buildable 21335
Build 29034: Run Core Tests