Page MenuHomePhabricator

Give sessions real PHIDs and slightly modernize session queries
ClosedPublic

Authored by epriestley on Dec 13 2018, 6:34 PM.

Details

Summary

Ref T13222. See PHI873. I'm preparing to introduce a new MFA "Challenge" table which stores state about challenges we've issued (to bind challenges to sessions and prevent most challenge reuse).

This table will reference sessions (since each challenge will be bound to a particular session) but sessions currently don't have PHIDs. Give them PHIDs and slightly modernize some related code.

Test Plan
  • Ran migrations.
  • Verified table got PHIDs.
  • Used var_dump() to dump an organic user session.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 13 2018, 6:34 PM
Owners added a subscriber: Restricted Owners Package.Dec 13 2018, 6:34 PM
epriestley requested review of this revision.Dec 13 2018, 6:36 PM
amckinley accepted this revision.Dec 13 2018, 7:48 PM
This revision is now accepted and ready to land.Dec 13 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.