HomePhabricator

Tailor the "no reviewers on this revision" warnings to handle the case where…

Tags
None
Referenced Files
F6026834: Screen Shot 2018-11-24 at 6.40.55 AM.png
Nov 28 2018, 9:50 PM
F6026833: Screen Shot 2018-11-24 at 6.40.51 AM.png
Nov 28 2018, 9:50 PM
F6026832: Screen Shot 2018-11-24 at 6.41.12 AM.png
Nov 28 2018, 9:50 PM
Subscribers
None

Description

Tailor the "no reviewers on this revision" warnings to handle the case where all reviewers have resigned

Summary:
Ref T13216. See PHI985. We currently use a banner to warn you when a revision has no reviewers or only disabled users, but since the changes to track "Resign" more explicilty we'll no longer warn you if everyone has resigned.

(Previously, they'd no longer be reviewers, so you'd end up with the "no reviewers are assigned" warning if everyone resigned.)

This can still interact slightly oddly with some states (e.g., only a package or project reviewer) but I'd like to wait for T731 to tighten those cases up, and they're more advanced/unusual.

Test Plan:

Screen Shot 2018-11-24 at 6.41.12 AM.png (942×1 px, 163 KB)

Screen Shot 2018-11-24 at 6.40.51 AM.png (942×1 px, 161 KB)

Screen Shot 2018-11-24 at 6.40.55 AM.png (942×1 px, 160 KB)

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13216

Differential Revision: https://secure.phabricator.com/D19834