Page MenuHomePhabricator

Tailor the "no reviewers on this revision" warnings to handle the case where all reviewers have resigned

Authored by epriestley on Nov 24 2018, 2:44 PM.



Ref T13216. See PHI985. We currently use a banner to warn you when a revision has no reviewers or only disabled users, but since the changes to track "Resign" more explicilty we'll no longer warn you if everyone has resigned.

(Previously, they'd no longer be reviewers, so you'd end up with the "no reviewers are assigned" warning if everyone resigned.)

This can still interact slightly oddly with some states (e.g., only a package or project reviewer) but I'd like to wait for T731 to tighten those cases up, and they're more advanced/unusual.

Test Plan

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 24 2018, 2:44 PM
epriestley requested review of this revision.Nov 24 2018, 2:46 PM
amckinley accepted this revision.Nov 28 2018, 6:30 PM
This revision is now accepted and ready to land.Nov 28 2018, 6:30 PM
This revision was automatically updated to reflect the committed changes.