Replace the primary scrollbar with a fake one to prepare for a persistent…
Auditedc40bc0c8bf75
Actions

Description

Replace the primary scrollbar with a fake one to prepare for a persistent chat column

Summary:
Ref T7014. With a mouse plugged in, multi-panel UIs are pretty hideous on OSX. This is somewhat offputting for me in Conpherence, and really jumps out at me with the new column mocks in T7014.

Sites like Twitch and Facebook approach this by emulating the touchpad scrollbar to achieve a more aesthetic UI. Use a similar approach.

This:

Replaces the main scrollbar with a prettier fake one.
This prepares the standard page frame for a persistent chat column.

Test Plan:

Seems to work properly on OSX, Chrome and Firefox. Haven't tested on IE; my Windows setup is pretty iffy at the moment.
Tried Conpherence.
Tried Workboards.

Reviewers: btrahan, chad

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7014

Differential Revision: https://secure.phabricator.com/D11472

Details

Auditors

fabe
johnny-bit

Provenance

epriestley	Authored on
epriestley	Pushed on Jan 23 2015, 9:29 PM

Reviewer

btrahan

Differential Revision

D11472: Replace the primary scrollbar with a fake one to prepare for a persistent chat column

Parents

rP45ae9cf340c7: Move PhabricatorCrumbs to PHUICrumbs

Branches

Unknown

Tags

Unknown

Tasks

T7014: Annouce Persistent Chat option in Conpherence

Event Timeline

epriestley committed rPc40bc0c8bf75: Replace the primary scrollbar with a fake one to prepare for a persistent… (authored by epriestley).Jan 23 2015, 9:29 PM

epriestley added a task: T7014: Annouce Persistent Chat option in Conpherence.

This feels very broken on mobile/iOS.
Not only am i unable to fast scroll to the bottom (fast swipe down won't work, it will always scroll just a little bit) it will also randomly stop scrolling down as if there was no more content. I was only able to comment on this commit by clicking on the last file and scrolling down a little bit. Simply scrolling over the diff to the bottom didn't work.(got stuck somewhere during the first file and wouldn't let me scroll down further)

Yeah this feels broken, wonder if just adding -webkit-overflow-scrolling: touch will fix it, I'll try it out later tonight.

I've noticed a couple of other glitches here too, working on some tweaks.

(also some crumb ui issues, but those should resolve when I update the crumb ui)

epriestley mentioned this in D11480: Don't activate JX.Scrollbar if we don't need to.Jan 24 2015, 2:18 AM

See D11480.

epriestley mentioned this in rP512b17361845: Don't activate JX.Scrollbar if we don't need to.Jan 24 2015, 2:22 AM

For me This creates very broken experience with scrollbar. For example: try scrolling to around middle of long page. Now click on scrollbar and try to set it to 3/4 or 1/4 point on page - it jumps to top and You get scroll from top...

I use Firefox on Linux (GTK).

Can you be more specific to your OS/Browser version and Phabricator version? We've shipped several fixes since this landed.

epriestley mentioned this in D11483: Fix an issue with dragging the scrollbar handle from a noninitial position.Jan 24 2015, 9:58 PM

Should be fixed by D11483.

I do see some wonkiness in FF on my Ubuntu machine, but its version 29 and I can't seem to convince it to update. lul.

epriestley mentioned this in rP25fc168c95e8: Fix an issue with dragging the scrollbar handle from a noninitial position.Jan 24 2015, 10:00 PM

Hey @chad - My OS is Gentoo (that won't help anybody ;) rolling release all the way) + Firerfox is 35.

Phabricator is @ HEAD updated 30 minutes before making comment. Issue is also present on secure.phabricator.com :)

This issue should be fixed on this install now (as of about 30 seconds ago, I just pushed it). Does it still repro for you?

@epriestley - as of rP25fc168c95e81697d3ce4b9066c14e18cd579e84 works for me on secure.phabricator.com, my local install and on my production server :)