Page MenuHomePhabricator

Fix an issue with dragging the scrollbar handle from a noninitial position
ClosedPublic

Authored by epriestley on Jan 24 2015, 9:58 PM.
Tags
None
Referenced Files
F14008861: D11483.diff
Wed, Oct 30, 6:45 AM
F14008115: D11483.id27624.diff
Tue, Oct 29, 3:54 PM
F13998057: D11483.diff
Thu, Oct 24, 7:24 AM
F13993085: D11483.diff
Tue, Oct 22, 8:34 PM
F13955451: D11483.id27624.diff
Oct 14 2024, 1:30 AM
Unknown Object (File)
Oct 13 2024, 10:59 PM
Unknown Object (File)
Sep 27 2024, 6:28 AM
Unknown Object (File)
Sep 23 2024, 1:04 PM
Subscribers

Details

Summary

See <rPc40bc0c8bf75#4050>. Repro steps:

  • Scroll partway down the page.
  • Click and drag the scroll handle.

Prior to this diff, the handle incorrectly jumps back to the top of the page. This is because we didn't store the handle's original position. (In testing, I always dragged from near the top of the page, and I don't normally drag scrollbars, so I didn't notice this.)

Test Plan

Clicking and dragging a partially scrolled handle now works correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with dragging the scrollbar handle from a noninitial position.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
This revision is now accepted and ready to land.Jan 24 2015, 10:00 PM
This revision was automatically updated to reflect the committed changes.