HomePhabricator

"fix" github scope-upgrade flow

Description

"fix" github scope-upgrade flow

Summary:
Can't say I know what I'm doing here, but this fixes an the upgrade-scope flow for landing-to-github.

Without this change, it looks like the submit button makes the browser (Chrome and msie) make the call in the background, instead of hijacking the window.
With it, it works like it should.

Test Plan: try to land with weak token, click "Refresh..", see GitHub button.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9407

Details

Provenance
aviveyAuthored on
epriestleyCommitted on Jun 7 2014, 7:05 PM
epriestleyPushed on Jun 7 2014, 7:05 PM
Reviewer
Blessed Reviewers
Differential Revision
D9407: "fix" github scope-upgrade flow
Parents
rP6c48f11a07e0: Move the "Advanced Configuration" documentation.
Branches
Unknown
Tags
Unknown

Event Timeline