Page MenuHomePhabricator

"fix" github scope-upgrade flow
ClosedPublic

Authored by avivey on Jun 6 2014, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 10:20 PM
Unknown Object (File)
Fri, Dec 13, 9:51 PM
Unknown Object (File)
Fri, Dec 13, 1:50 PM
Unknown Object (File)
Thu, Dec 12, 2:41 AM
Unknown Object (File)
Wed, Dec 11, 7:09 AM
Unknown Object (File)
Wed, Dec 11, 4:13 AM
Unknown Object (File)
Thu, Dec 5, 10:07 AM
Unknown Object (File)
Mon, Dec 2, 5:37 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPb6bc8b8c0f8d: "fix" github scope-upgrade flow
Summary

Can't say I know what I'm doing here, but this fixes an the upgrade-scope flow for landing-to-github.

Without this change, it looks like the submit button makes the browser (Chrome and msie) make the call in the background, instead of hijacking the window.
With it, it works like it should.

Test Plan

try to land with weak token, click "Refresh..", see GitHub button.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avivey retitled this revision from to "fix" github scope-upgrade flow.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
avivey edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 7:05 PM
epriestley updated this revision to Diff 22485.

Closed by commit rPb6bc8b8c0f8d (authored by @avivey, committed by @epriestley).