Allow menu items to be edited again
ClosedPublic

Authored by epriestley on Jan 31 2017, 9:26 PM.

Details

Summary

Ref T12174. We now require that we can figure out a valid "edit mode" (global vs custom/personal) before we hit EditEngine. Since the EditEngine routes don't have an itemID, they would failu to figure out the mode and just 404.

Let the engine use id (from EditEngine) if itemID (from MenuEngine) isn't present in the route.

Test Plan
  • Edited some menu items on Home / Projects.
  • (I think I tested this, then broke it, originally.)

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Jan 31 2017, 9:26 PM
chad accepted this revision.Jan 31 2017, 9:30 PM
This revision is now accepted and ready to land.Jan 31 2017, 9:30 PM
This revision was automatically updated to reflect the committed changes.