Page MenuHomePhabricator

Allow menu items to be edited again
ClosedPublic

Authored by epriestley on Jan 31 2017, 9:26 PM.
Tags
None
Referenced Files
F15460399: D17280.id41568.diff
Mon, Mar 31, 10:38 PM
F15459516: D17280.id41570.diff
Mon, Mar 31, 1:44 PM
F15456644: D17280.id.diff
Sun, Mar 30, 10:59 AM
F15453161: D17280.diff
Sat, Mar 29, 9:51 AM
F15444730: D17280.id.diff
Thu, Mar 27, 10:55 AM
F15388147: D17280.diff
Sat, Mar 15, 3:22 AM
F15338009: D17280.diff
Mar 9 2025, 8:49 AM
F15321795: D17280.diff
Mar 6 2025, 11:17 PM
Subscribers
None

Details

Summary

Ref T12174. We now require that we can figure out a valid "edit mode" (global vs custom/personal) before we hit EditEngine. Since the EditEngine routes don't have an itemID, they would failu to figure out the mode and just 404.

Let the engine use id (from EditEngine) if itemID (from MenuEngine) isn't present in the route.

Test Plan
  • Edited some menu items on Home / Projects.
  • (I think I tested this, then broke it, originally.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 31 2017, 9:30 PM
This revision was automatically updated to reflect the committed changes.