HomePhabricator

Correct a mangled translation string in "bin/phd log --id X"

Description

Correct a mangled translation string in "bin/phd log --id X"

Summary:
Ref T13210. See PHI930. This translation is wrong: the parameter is a comma-separated list as a string, but the USEnglish translation provides alternatives. We can't select among alternatives based on a random string (it isn't a plurality value to let us select "chair" vs "chairs", and isn't a gender value to let us select "his profile" vs "her profile") so we get an error.

But the string itself is also misleading, since "bin/phd log --id A --id B --id C" will say "none of these are valid" if any of them are invalid.

Instead, just tell the user explicitly about the first problem.

Test Plan:

  • Ran bin/phd log --id with good (got logs) and bad IDs (got sensible error).
  • Ran bin/phd log with any logs (got logs) and (simluated) without any logs (got error).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13210

Differential Revision: https://secure.phabricator.com/D19755

Details

Provenance
epriestleyAuthored on Oct 24 2018, 4:38 PM
epriestleyPushed on Oct 26 2018, 1:13 PM
Reviewer
amckinley
Differential Revision
D19755: Correct a mangled translation string in "bin/phd log --id X"
Parents
rP5f3a7cb41b17: Expose Drydock leases via Conduit
Branches
Unknown
Tags
Unknown
Tasks
T13210: Plans: 2018 Week 41-44 Bonus Content
Build Status
Buildable 21051
Build 28604: Run Core Tests