Page MenuHomePhabricator

Correct a mangled translation string in "bin/phd log --id X"
ClosedPublic

Authored by epriestley on Oct 24 2018, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 6:37 AM
Unknown Object (File)
Sun, Feb 9, 6:37 AM
Unknown Object (File)
Sun, Feb 9, 6:37 AM
Unknown Object (File)
Tue, Jan 28, 4:17 AM
Unknown Object (File)
Tue, Jan 28, 4:17 AM
Unknown Object (File)
Tue, Jan 28, 4:17 AM
Unknown Object (File)
Sat, Jan 25, 3:44 PM
Unknown Object (File)
Sat, Jan 25, 2:30 AM
Subscribers
None

Details

Summary

Ref T13210. See PHI930. This translation is wrong: the parameter is a comma-separated list as a string, but the USEnglish translation provides alternatives. We can't select among alternatives based on a random string (it isn't a plurality value to let us select "chair" vs "chairs", and isn't a gender value to let us select "his profile" vs "her profile") so we get an error.

But the string itself is also misleading, since "bin/phd log --id A --id B --id C" will say "none of these are valid" if any of them are invalid.

Instead, just tell the user explicitly about the first problem.

Test Plan
  • Ran bin/phd log --id with good (got logs) and bad IDs (got sensible error).
  • Ran bin/phd log with any logs (got logs) and (simluated) without any logs (got error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable