Page MenuHomePhabricator

Correct a mangled translation string in "bin/phd log --id X"
ClosedPublic

Authored by epriestley on Oct 24 2018, 4:41 PM.
Tags
None
Referenced Files
F19103890: D19755.id.diff
Fri, Dec 5, 12:04 PM
F19097294: D19755.diff
Thu, Dec 4, 12:58 PM
F18837075: D19755.diff
Oct 27 2025, 4:17 AM
F18799309: D19755.id47188.diff
Oct 17 2025, 1:10 PM
F18785844: D19755.id47206.diff
Oct 14 2025, 1:14 PM
F18699109: D19755.id.diff
Sep 27 2025, 12:26 PM
F18686670: D19755.diff
Sep 26 2025, 1:22 PM
F18657668: D19755.diff
Sep 23 2025, 2:51 AM
Subscribers
None

Details

Summary

Ref T13210. See PHI930. This translation is wrong: the parameter is a comma-separated list as a string, but the USEnglish translation provides alternatives. We can't select among alternatives based on a random string (it isn't a plurality value to let us select "chair" vs "chairs", and isn't a gender value to let us select "his profile" vs "her profile") so we get an error.

But the string itself is also misleading, since "bin/phd log --id A --id B --id C" will say "none of these are valid" if any of them are invalid.

Instead, just tell the user explicitly about the first problem.

Test Plan
  • Ran bin/phd log --id with good (got logs) and bad IDs (got sensible error).
  • Ran bin/phd log with any logs (got logs) and (simluated) without any logs (got error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable