HomePhabricator

Aphlict - fix getActiveListenerCount return value

Description

Aphlict - fix getActiveListenerCount return value

Summary: Ref T7126. Dictionaries do not have a length property unlike arrays resulting in the getActiveListenerCount() function returning undefined results. Using the length property on the array of keys will work.

Test Plan: Using wscat to generate multiple connections to the server, establish new ones and close others while keeping an eye on the displayed clients.active value.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7126

Differential Revision: https://secure.phabricator.com/D11647

Details

Provenance
pmoreauAuthored on
epriestleyCommitted on Feb 3 2015, 3:01 PM
epriestleyPushed on Feb 3 2015, 3:01 PM
Reviewer
Blessed Reviewers
Differential Revision
D11647: Aphlict - fix getActiveListenerCount return value
Parents
rP9df4cb37d405: Fix printing with new scroll
Branches
Unknown
Tags
Unknown
Tasks
T7126: `clients.active` field is not present on the `notification/status` page