Page MenuHomePhabricator

Aphlict - fix getActiveListenerCount return value
ClosedPublic

Authored by pmoreau on Feb 3 2015, 2:58 PM.

Details

Summary

Ref T7126. Dictionaries do not have a length property unlike arrays resulting in the getActiveListenerCount() function returning undefined results. Using the length property on the array of keys will work.

Test Plan

Using wscat to generate multiple connections to the server, establish new ones and close others while keeping an eye on the displayed clients.active value.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pmoreau retitled this revision from to Aphlict - fix getActiveListenerCount return value.
pmoreau updated this object.
pmoreau edited the test plan for this revision. (Show Details)
pmoreau added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 3:00 PM
This revision was automatically updated to reflect the committed changes.