HomePhabricator

Fix an issue where "Import Columns" could fail on a board for a project with…

Description

Fix an issue where "Import Columns" could fail on a board for a project with milestones

Summary:
See PHI1025. When you "Import Columns", we test if you're trying to import into a board that already has columns. However, this test is too broad (it incorrectly detects "proxy" columns for milestones as columns) and not user-friendly (it returns 400 instead of a readable error).

Correct these issues, and refine some of the logic around proxy columns.

Test Plan:

  • Created a project, A.
  • Created a milestone under that project.
  • Imported another project's columns to A's workboard.
    • Before change: Unhelpful 400.
    • After change: import worked fine.
  • Also, hit the new error dialogs and read through them.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19978

Details

Provenance
epriestleyAuthored on Jan 16 2019, 2:36 PM
epriestleyPushed on Jan 17 2019, 12:15 AM
Reviewer
amckinley
Differential Revision
D19978: Fix an issue where "Import Columns" could fail on a board for a project with milestones
Parents
rP0a0afa489a5d: Wordsmith inbound mail documentation more thoroughly
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21569
Build 29394: Run Core Tests