Differential D19978

Fix an issue where "Import Columns" could fail on a board for a project with milestones
ClosedPublic
Actions

Authored by epriestley on Jan 16 2019, 2:39 PM.

Details

Reviewers

Commits

rPa1516fefb67a: Fix an issue where "Import Columns" could fail on a board for a project with…

Summary

See PHI1025. When you "Import Columns", we test if you're trying to import into a board that already has columns. However, this test is too broad (it incorrectly detects "proxy" columns for milestones as columns) and not user-friendly (it returns 400 instead of a readable error).

Correct these issues, and refine some of the logic around proxy columns.

Test Plan

Created a project, A.
Created a milestone under that project.
Imported another project's columns to A's workboard.
- Before change: Unhelpful 400.
- After change: import worked fine.
Also, hit the new error dialogs and read through them.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 16 2019, 2:39 PM

Harbormaster completed remote builds in B21533: Diff 47680.Jan 16 2019, 2:40 PM

epriestley requested review of this revision.Jan 16 2019, 2:40 PM

amckinley accepted this revision.Jan 17 2019, 12:03 AM

amckinley added inline comments.

src/applications/project/controller/PhabricatorProjectBoardImportController.php
57	"Source Workboard Has No Columns", if I understand this right.

This revision is now accepted and ready to land.Jan 17 2019, 12:03 AM

epriestley added inline comments.Jan 17 2019, 12:04 AM

src/applications/project/controller/PhabricatorProjectBoardImportController.php
57	Ah, yeah, I think your phrasing is more clear. You just "targeted" this workboard by typing in the name, but it's not really self-evident whether "target" means "source" or "destination".