HomePhabricator

Fix infinite loop in PhutilFileTree

Description

Fix infinite loop in PhutilFileTree

Summary: In one of our diff we have files with name '10.8' and '10.80' in the same dir, which caused infinite loop since numerically they are the same hence getNextSibling() call on 10.80 will always gets itself.

Test Plan: Load the diff with fix.

Reviewers: epriestley, lifeihuang, JoelB, cdentel, Blessed Reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8091

Details

Provenance
sowedanceAuthored on
epriestleyCommitted on Jan 29 2014, 6:04 PM
epriestleyPushed on Jan 29 2014, 6:04 PM
Reviewer
epriestley
Differential Revision
D8091: Fix infinite loop in PhutilFileTree
Parents
rPHU54dbec7ac274: Fixed missing symbols
Branches
Unknown
Tags
Unknown

Event Timeline