Page MenuHomePhabricator

Fix infinite loop in PhutilFileTree
ClosedPublic

Authored by sowedance on Jan 29 2014, 12:38 AM.
Tags
None
Referenced Files
F15432024: D8091.id.diff
Mon, Mar 24, 3:54 PM
F15393071: D8091.id18312.diff
Sat, Mar 15, 7:25 PM
Unknown Object (File)
Mar 2 2025, 12:15 AM
Unknown Object (File)
Feb 24 2025, 11:26 AM
Unknown Object (File)
Feb 22 2025, 8:53 PM
Unknown Object (File)
Feb 21 2025, 7:05 PM
Unknown Object (File)
Jan 25 2025, 7:40 AM
Unknown Object (File)
Jan 23 2025, 3:16 PM

Details

Summary

In one of our diff we have files with name '10.8' and '10.80' in the same dir, which caused infinite loop since numerically they are the same hence getNextSibling() call on 10.80 will always gets itself.

Test Plan

Load the diff with fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline