Fix infinite loop in PhutilFileTree
ClosedPublic
Actions

Authored by • sowedance on Jan 29 2014, 12:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 9:52 PM

	Unknown Object (File)
	Sun, Apr 21, 3:56 PM

	Unknown Object (File)
	Thu, Apr 18, 4:54 PM

	Unknown Object (File)
	Wed, Apr 17, 3:02 PM

	Unknown Object (File)
	Tue, Apr 16, 12:50 AM

	Unknown Object (File)
	Thu, Apr 11, 7:30 AM

	Unknown Object (File)
	Fri, Mar 29, 3:06 PM

	Unknown Object (File)
	Mar 22 2024, 3:11 PM

Subscribers

Details

Reviewers

cdentel
epriestley
lifeihuang
JoelB

Group Reviewers

Blessed Reviewers

Commits

rPHUf12025abc05b: Fix infinite loop in PhutilFileTree

Summary

In one of our diff we have files with name '10.8' and '10.80' in the same dir, which caused infinite loop since numerically they are the same hence getNextSibling() call on 10.80 will always gets itself.

Test Plan

Load the diff with fix.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Durr, thanks.

Closed by commit rPHUf12025abc05b (authored by @sowedance, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

filesystem/

PhutilFileTree.php

2 lines

Diff 18312

View Options

src/filesystem/PhutilFileTree.php

Fix infinite loop in PhutilFileTreeClosedPublicActions