HomePhabricator

Pass HGPLAIN in the environment when testing "hg" version

Authored by epriestley on Sep 15 2017, 12:40 PM.

Description

Pass HGPLAIN in the environment when testing "hg" version

Summary:
See T12972. In Phabricator, we always execute with HGPLAIN but this didn't make it into the standalone binary analyzer:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/diffusion/protocol/DiffusionMercurialCommandEngine.php;c71cb944a42851de00b2129f15899f7681b0f7ed$31

HGPLAIN disables translations and extensions which may make hg version do something unexpected.

Test Plan: Verified my local version of Mercurial is still identified correctly in Config. I have yet to figure out how to install non-English Mercurial so I didn't truly test this, but our use of HGPLAIN in other contexts is well-established.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18610

Details

Committed
epriestleySep 15 2017, 3:39 PM
Pushed
epriestleySep 15 2017, 3:39 PM
Reviewer
amckinley
Differential Revision
D18610: Pass HGPLAIN in the environment when testing "hg" version
Parents
rPHUceeaf5ebea1c: Adding support for CloudFormation API calls
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18466
Build 24867: Run Core Tests