Page MenuHomePhabricator

Pass HGPLAIN in the environment when testing "hg" version
ClosedPublic

Authored by epriestley on Sep 15 2017, 12:43 PM.
Tags
None
Referenced Files
F18406631: D18610.diff
Sat, Aug 30, 12:22 AM
F18392693: D18610.id.diff
Fri, Aug 29, 8:30 AM
F18383447: D18610.diff
Thu, Aug 28, 11:02 PM
F18274423: D18610.diff
Fri, Aug 22, 6:16 PM
F18099530: D18610.id44686.diff
Sat, Aug 9, 5:56 AM
F17979544: D18610.id44680.diff
Fri, Aug 1, 6:27 PM
F17901949: D18610.id.diff
Jul 29 2025, 10:03 AM
F17886395: D18610.diff
Jul 29 2025, 12:58 AM
Subscribers
None

Details

Summary

See T12972. In Phabricator, we always execute with HGPLAIN but this didn't make it into the standalone binary analyzer:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/diffusion/protocol/DiffusionMercurialCommandEngine.php;c71cb944a42851de00b2129f15899f7681b0f7ed$31

HGPLAIN disables translations and extensions which may make hg version do something unexpected.

Test Plan

Verified my local version of Mercurial is still identified correctly in Config. I have yet to figure out how to install non-English Mercurial so I didn't truly test this, but our use of HGPLAIN in other contexts is well-established.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable