Page MenuHomePhabricator

Pass HGPLAIN in the environment when testing "hg" version
ClosedPublic

Authored by epriestley on Sep 15 2017, 12:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:00 AM
Unknown Object (File)
Tue, Apr 23, 6:37 PM
Unknown Object (File)
Fri, Apr 19, 6:49 PM
Unknown Object (File)
Mon, Apr 8, 2:40 AM
Unknown Object (File)
Fri, Apr 5, 4:24 PM
Unknown Object (File)
Fri, Mar 29, 12:35 PM
Unknown Object (File)
Mar 28 2024, 4:07 AM
Unknown Object (File)
Mar 27 2024, 12:21 AM
Subscribers
None

Details

Summary

See T12972. In Phabricator, we always execute with HGPLAIN but this didn't make it into the standalone binary analyzer:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/diffusion/protocol/DiffusionMercurialCommandEngine.php;c71cb944a42851de00b2129f15899f7681b0f7ed$31

HGPLAIN disables translations and extensions which may make hg version do something unexpected.

Test Plan

Verified my local version of Mercurial is still identified correctly in Config. I have yet to figure out how to install non-English Mercurial so I didn't truly test this, but our use of HGPLAIN in other contexts is well-established.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable