HomePhabricator

Make setCWD() with bad paths safer

Description

Make setCWD() with bad paths safer

Summary: Ref T10853. This isn't a complete fix, but should prevent the most serious mistakes with setCWD() on bad paths.

Test Plan:

  • Wrote a script using setCWD().
  • Gave it a bad path: got an explicit error.
  • Gave it a good path: things worked great.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10853

Differential Revision: https://secure.phabricator.com/D15785

Details

Provenance
epriestleyAuthored on Apr 22 2016, 12:23 PM
epriestleyPushed on Apr 22 2016, 3:10 PM
Reviewer
chad
Differential Revision
D15785: Make setCWD() with bad paths safer
Parents
rPHU1341c014ca7c: Share Env/CWD methods between Passthru + ExecFuture, expose Env
Branches
Unknown
Tags
Unknown
Tasks
T10853: Make `setCWD('/does/not/exist')` safer on ExecFuture
Build Status
Buildable 11900
Build 14951: Run Core Tests