Page MenuHomePhabricator

Make setCWD() with bad paths safer
ClosedPublic

Authored by epriestley on Apr 22 2016, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 24, 3:18 AM
Unknown Object (File)
Fri, Nov 18, 3:03 PM
Unknown Object (File)
Thu, Nov 10, 10:51 AM
Unknown Object (File)
Oct 31 2022, 6:52 AM
Unknown Object (File)
Oct 28 2022, 7:19 PM
Unknown Object (File)
Oct 19 2022, 5:27 PM
Unknown Object (File)
Oct 19 2022, 5:26 PM
Unknown Object (File)
Oct 19 2022, 5:26 PM
Subscribers
None

Details

Summary

Ref T10853. This isn't a complete fix, but should prevent the most serious mistakes with setCWD() on bad paths.

Test Plan
  • Wrote a script using setCWD().
  • Gave it a bad path: got an explicit error.
  • Gave it a good path: things worked great.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make setCWD() with bad paths safer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2016, 2:31 PM
This revision was automatically updated to reflect the committed changes.