Don't throw `PhutilMissingSymbolException` from within `method_exists` and…
14765d36f83a
Actions

Description

Don't throw PhutilMissingSymbolException from within method_exists and property_exists calls

Summary: Ref T1116. Fixes T9954. It seems that method_exists and propery_exists can trigger PHP autoloaders as well.

Test Plan: Fixed the issue described in T9954.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T1116, T9954

Differential Revision: https://secure.phabricator.com/D14860

Details

Provenance

joshuaspence	Authored on
industry	Pushed on Dec 23 2015, 12:56 PM

Reviewer

Blessed Reviewers

Differential Revision

D14860: Don't throw `PhutilMissingSymbolException` from within `method_exists` and `property_exists` calls

Parents

rPHUb0843cba1270: Add more useful languages

Branches

Unknown

Tags

Unknown

Tasks

T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function
T9954: Cannot change a fulfiled promise to rejected

Build Status

Buildable 9746
Build 11702: Run Core Tests

Event Timeline

joshuaspence committed rPHU14765d36f83a: Don't throw `PhutilMissingSymbolException` from within `method_exists` and… (authored by joshuaspence).Dec 23 2015, 12:56 PM

joshuaspence added a task: T9954: Cannot change a fulfiled promise to rejected.

joshuaspence added a task: T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.

Harbormaster completed building B9746: rPHU14765d36f83a: Don't throw `PhutilMissingSymbolException` from within `method_exists` and….Dec 23 2015, 12:57 PM

altendky mentioned this in T9441: Cygwin PHP segfaults with arcanist.Dec 24 2015, 12:53 AM

epriestley mentioned this in 2015 Week 52 (Late December).Dec 26 2015, 11:16 AM

Changes (1)

Path

Size

src/

__phutil_library_init__.php

rPHU14765d36f83a

View Options

src/__phutil_library_init__.php