Page MenuHomePhabricator

Improve performance of two recent commit migrations
ClosedPublic

Authored by epriestley on Nov 14 2018, 5:45 PM.
Tags
None
Referenced Files
F18112242: D19802.id47307.diff
Tue, Aug 12, 4:15 PM
F18112241: D19802.id47294.diff
Tue, Aug 12, 4:15 PM
F18112240: D19802.id.diff
Tue, Aug 12, 4:15 PM
F18109973: D19802.diff
Mon, Aug 11, 3:31 PM
F18095211: D19802.diff
Thu, Aug 7, 10:34 PM
F18088186: D19802.id47307.diff
Wed, Aug 6, 7:09 AM
F17948901: D19802.id.diff
Thu, Jul 31, 10:22 PM
F17935197: D19802.id47294.diff
Wed, Jul 30, 11:12 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13216. See PHI959. These two recent migrations can be expressed more efficiently:

  • When updating commit audit statuses, the field isn't JSON encoded or anything so we can just issue several bulk UPDATEs.
  • When inserting mail keys, we can batch them in groups of 100.
Test Plan

Used bin/storage upgrade -f --apply phabricator:... to reapply patches. Saw equivalent behavior and faster runtimes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Nov 14 2018, 5:45 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 14 2018, 5:46 PM
Harbormaster failed remote builds in B21143: Diff 47294!

Stacked on qsprintf() stuff.

This revision is now accepted and ready to land.Nov 15 2018, 3:28 AM
This revision was automatically updated to reflect the committed changes.