Page MenuHomePhabricator

Improve performance of two recent commit migrations
ClosedPublic

Authored by epriestley on Wed, Nov 14, 5:45 PM.

Details

Summary

Ref T13216. See PHI959. These two recent migrations can be expressed more efficiently:

  • When updating commit audit statuses, the field isn't JSON encoded or anything so we can just issue several bulk UPDATEs.
  • When inserting mail keys, we can batch them in groups of 100.
Test Plan

Used bin/storage upgrade -f --apply phabricator:... to reapply patches. Saw equivalent behavior and faster runtimes.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Nov 14, 5:45 PM
Owners added a subscriber: Restricted Owners Package.Wed, Nov 14, 5:45 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 14, 5:46 PM
Harbormaster failed remote builds in B21143: Diff 47294!
epriestley requested review of this revision.Wed, Nov 14, 6:03 PM

Stacked on qsprintf() stuff.

amckinley accepted this revision.Thu, Nov 15, 3:28 AM
This revision is now accepted and ready to land.Thu, Nov 15, 3:28 AM
This revision was automatically updated to reflect the committed changes.